-
Notifications
You must be signed in to change notification settings - Fork 210
【Hackathon 8th No.23】Improved Training of Wasserstein GANs 论文复现 #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! |
老师这个文档有需要修改的地方吗? |
之前大致看了一下应该有一些格式上的问题,如果没看过这个 https://paddlescience-docs.readthedocs.io/zh-cn/latest/zh/development/#3 的话可以参考教程预览一下,具体的等代码合了我再看一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还有一点小问题,请再修改一下~
- 当前文档中所有应该显示代码的部分是空的,因为code代码合入了,所以麻烦重新拉一下代码,以检查代码显示有没有问题
- 模型评估应该有预训练模型(.pdparams),以及该预训练模型下的指标(参考其他文档),发给我我返回一个地址然后写到文档里,以及如果有图片也可以一并给我
- PaddleScience/README.txt中的“案例列表”部分也需要一并改一下
我下载最新的paddlescience修改后,这里代码都可以显示没有复现出问题 |
通过网盘分享的文件:models.zip |
谢谢老师,已完成所有修改 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
老师这个还需要修改吗?为什么还没有合入啊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
PR changes
Describe
文档提交